[tor-bugs] #22221 [Core Tor/Tor]: CID 1405983 test_channelpadding.c dead code

[Tor Bug Tracker & Wiki]

#22221: CID 1405983 test_channelpadding.c dead code
--------------------------+------------------------------------
 Reporter:  catalyst      |          Owner:
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by mikeperry):

 * status:  needs_review => merge_ready


Comment:

 Ah, yes. This test was originally written to exercise a timer layer that
 limited the number of pending libevent timers. Since Nick added the timing
 wheel code, that layer was no longer needed and was removed. But it is
 still a good idea to exercise adding timers out of order, and adding
 timers with firing times before the currently scheduled batch. Fixing this
 loop order makes sure that happens, so this is good to go.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22221#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online