[tor-bugs] #22213 [Core Tor/Tor]: ROUTER_ADDED_NOTIFY_GENERATOR unused and can be removed

[Tor Bug Tracker & Wiki]

#22213: ROUTER_ADDED_NOTIFY_GENERATOR unused and can be removed
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:
     Type:  enhancement   |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 Replying to [comment:1 nickm]:
 > unless we think we're likely to want it in the future for some reason.

 I think we're not likely to use it. In the NOTIFY_GENERATOR case, we do:
 {{{
     if (r == ROUTER_ADDED_NOTIFY_GENERATOR) {
       /* Accepted with a message. */
       [...]
       write_http_status_line(conn, 400, msg);
 }}}

 but in the "else" case, we do:
 {{{
     } else {
       [...]
       write_http_status_line(conn, 400, msg);
 }}}

 So, we already have (and are using) a way to send a 400 response along
 with a message.

 The comment where it says we accepted the descriptor seems to be at odds
 with the 400 response code. In conclusion, I think this is a halfbaked
 mistake from many years ago. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22213#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online