[tor-bugs] #22210 [Core Tor/Tor]: circuit_is_acceptable is slow due to IP and fingerprint parsing
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed May 10 08:41:38 UTC 2017
#22210: circuit_is_acceptable is slow due to IP and fingerprint parsing
--------------------------+------------------------------------
Reporter: teor | Owner:
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor | Version: Tor: 0.2.8.12
Severity: Normal | Resolution:
Keywords: tor-hs | Actual Points:
Parent ID: | Points: 1
Reviewer: | Sponsor:
--------------------------+------------------------------------
Comment (by arma):
Replying to [ticket:22210 teor]:
> 2.10 min 100.0% 6.26 s circuit_is_acceptable
> 58.93 s 46.7% 1.05 s tor_addr_parse
> 1. Parsing IP addresses from strings out of node descriptors
To be precise, it looks like this one is from
{{{
const int family = tor_addr_parse(&addr,
conn->socks_request->address);
}}}
which is actually parsing IP addresses from strings in the socks request,
not the node descriptor.
For how that code came to be that way, see commit 2b22c0ae from #7582.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22210#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list