[tor-bugs] #22209 [Core Tor/Tor]: Channelpadding tests fail on kevent-based systems

[Tor Bug Tracker & Wiki]

#22209: Channelpadding tests fail on kevent-based systems
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:
         Type:  defect        |     Status:  new
     Priority:  High          |  Milestone:  Tor: 0.3.1.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 First observed on freebsd, reproduced on osx:
 {{{
 [532]$ ./src/test/test channelpadding/..
 channelpadding/channelpadding_decide_to_pad_channel: [forking] [warn]
 kevent: Bad file descriptor

   FAIL src/test/test_channelpadding.c:759: assert(tried_to_write_cell
 OP_EQ 1): 0 vs 1May 09 13:07:08.604 [err] tor_assertion_failed_: Bug:
 src/or/scheduler.c:398: scheduler_release_channel__real: Assertion
 channels_pending failed; aborting. (on Tor 0.3.1.0-alpha-dev
 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug: Assertion channels_pending failed in
 scheduler_release_channel__real at src/or/scheduler.c:398. Stack trace:
 (on Tor 0.3.1.0-alpha-dev 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     0   test
 0x000000010f350f49 log_backtrace + 73 (on Tor 0.3.1.0-alpha-dev
 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     1   test
 0x000000010f3b600e tor_assertion_failed_ + 318 (on Tor 0.3.1.0-alpha-dev
 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     2   test
 0x000000010f2de166 scheduler_release_channel__real + 310 (on Tor 0.3.1.0
 -alpha-dev 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     3   test
 0x000000010ee2b4bc channel_change_state + 1180 (on Tor 0.3.1.0-alpha-dev
 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     4   test
 0x000000010ee2ac52 channel_mark_for_close + 386 (on Tor 0.3.1.0-alpha-dev
 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     5   test
 0x000000010ee3b0e4 channel_free_list + 2308 (on Tor 0.3.1.0-alpha-dev
 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     6   test
 0x000000010ee3a4ef channel_free_all + 223 (on Tor 0.3.1.0-alpha-dev
 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     7   test
 0x000000010ea8a673 test_channelpadding_decide_to_pad_channel + 1283 (on
 Tor 0.3.1.0-alpha-dev 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     8   test
 0x000000010edf25d9 testcase_run_bare_ + 329 (on Tor 0.3.1.0-alpha-dev
 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     9   test
 0x000000010edf2374 testcase_run_one + 2932 (on Tor 0.3.1.0-alpha-dev
 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     10  test
 0x000000010edf3861 tinytest_main + 1553 (on Tor 0.3.1.0-alpha-dev
 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     11  test
 0x000000010edf0397 main + 1703 (on Tor 0.3.1.0-alpha-dev 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     12  libdyld.dylib
 0x00007fffa1660235 start + 1 (on Tor 0.3.1.0-alpha-dev 9f5b71a7cafbaf14)
 May 09 13:07:08.612 [err] Bug:     13  ???
 0x0000000000000002 0x0 + 2 (on Tor 0.3.1.0-alpha-dev 9f5b71a7cafbaf14)
 [Lost connection!]
   [channelpadding_decide_to_pad_channel FAILED]
 channelpadding/channelpadding_negotiation: [forking] OK
 channelpadding/channelpadding_consensus: [forking] [warn] kevent: Bad file
 descriptor

   FAIL src/test/test_channelpadding.c:398: assert(tried_to_write_cell
 OP_EQ 1): 0 vs 1
   [channelpadding_consensus FAILED]
 channelpadding/channelpadding_timers: [forking] [warn] kevent: Bad file
 descriptor

   FAIL src/test/test_channelpadding.c:324: assert(tried_to_write_cell
 OP_EQ CHANNELS_TO_TEST): 0 vs 100
   [channelpadding_timers FAILED]
 3/4 TESTS FAILED. (0 skipped)
 }}}

 The problem might be because of the "kevent: bad file descriptor" thing;
 there might be a libevent mainloop that is not surviving across fork(), or
 is getting closed somewhere.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22209>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online