[tor-bugs] #4998 [Core Tor/Tor]: MyFamily as a list

[Tor Bug Tracker & Wiki]

#4998: MyFamily as a list
----------------------------------------+----------------------------------
 Reporter:  weasel                      |          Owner:  Jigsaw52
     Type:  defect                      |         Status:  merge_ready
 Priority:  Medium                      |      Milestone:  Tor:
                                        |  0.3.1.x-final
Component:  Core Tor/Tor                |        Version:  Tor:
                                        |  0.2.3.11-alpha
 Severity:  Normal                      |     Resolution:
 Keywords:  tor-relay lorax easy intro  |  Actual Points:
Parent ID:  #15060                      |         Points:
 Reviewer:                              |        Sponsor:
----------------------------------------+----------------------------------
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 Oh, I see what you did.  Yes, you're correct there.  The code looks like
 it should work.

 One thing that we try not to do any more, though: we try not to rewrite
 values that could get written back into the torrc by a SAVECONF command.
 What we usually do instead now is, when we want to normalize a
 configuration value, normalize it into a separate field of or_options_t.
 What do you think of the patch I've made on top of your branch, in `my-
 family-list-fix-4498` in my public repository?  The URL is

 https://gitweb.torproject.org/nickm/tor.git/log/?h=my-family-list-fix-4498

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4998#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online