[tor-bugs] #18100 [Core Tor/Tor]: src/or/connection_edge.c typo

[Tor Bug Tracker & Wiki]

#18100: src/or/connection_edge.c typo
-------------------------------------------------+-------------------------
 Reporter:  jirib                                |          Owner:
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.9
 Severity:  Normal                               |     Resolution:
 Keywords:  isaremoved, nickwants029, lorax,     |  Actual Points:
  tor-03-unspecified-201612                      |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:20 d4fq0fQAgoJ]:
 > System: Linux 4.10.5-1-ARCH x86_64, tor 0.2.9.9
 >
 > It appears to me that TPROXYing only works for me when connection
 tracking is active. When I apply the patch TPROXYing works for me no
 matter if conntection tracking is active or not.
 >
 > ...
 > Looking at the code it seems that getsockopt() is called. The patch
 activates a code path where getsockname() is called instead which seems to
 make it work even if no connection tracking is active. Maybe the author of
 that code can shed more light into that?

 I think the behaviour you describe is what we want.

 I re-wrote the code to make it behave consistently and improve how it was
 structured back in early 2016.

 I don't know enough about transparent proxying to say anything else with
 any confidence.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18100#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online