[tor-bugs] #21905 [Applications/Tor Browser]: Allow third-party cookies as we are isolating them to the first party in ESR52

[Tor Bug Tracker & Wiki]

#21905: Allow third-party cookies as we are isolating them to the first party in
ESR52
---------------------------------------------+--------------------------
 Reporter:  gk                               |          Owner:  tbb-team
     Type:  enhancement                      |         Status:  new
 Priority:  Medium                           |      Milestone:
Component:  Applications/Tor Browser         |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  tbb-usability-website, ff52-esr  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+--------------------------

Comment (by cypherpunks):

 As ip-check.info states, this is equal to #21756 in tracking aspect. So,
 no problem to enable it.
 Also torbutton requires some clean up, as it still uses
 `privacy.thirdparty.isolate`, resulting in:
 {{{
 15:25:20.836 NS_ERROR_UNEXPECTED: Component returned failure code:
 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getIntPref] 1
 torbutton.js:155
         torbutton_unique_pref_observer.observe
 chrome://torbutton/content/torbutton.js:155:40
         set_valueFromPreferences
 chrome://global/content/bindings/preferences.xml:364:13
         _setValue chrome://global/content/bindings/preferences.xml:191:15
         set_value chrome://global/content/bindings/preferences.xml:198:8
         userChangedValue
 chrome://global/content/bindings/preferences.xml:1281:15
         onxblcommand
 chrome://global/content/bindings/preferences.xml:1315:9
 }}}
 from
 {{{
         switch (data) {
             case "network.cookie.cookieBehavior":
                 var val =
 m_tb_prefs.getIntPref("network.cookie.cookieBehavior");
                 var block_thirdparty =
 m_tb_prefs.getIntPref("privacy.thirdparty.isolate") !== 0;
                 if (val == 0 && block_thirdparty) // Allow all cookies
                   m_tb_prefs.setIntPref("privacy.thirdparty.isolate", 0);
                 else if (val == 1 && !block_thirdparty) // Block third
 party cookies
                   m_tb_prefs.setIntPref("privacy.thirdparty.isolate", 2);
                 break;
             case "privacy.thirdparty.isolate":
                 torbutton_update_thirdparty_prefs();
                 break;
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21905#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online