[tor-bugs] #22101 [Core Tor/Tor]: Can't have relative DataDirectory with CookieAuthentication enabled

[Tor Bug Tracker & Wiki]

#22101: Can't have relative DataDirectory with CookieAuthentication enabled
--------------------------+------------------------------------
 Reporter:  pastly        |          Owner:  Jigsaw52
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by Jigsaw52):

 I've merged and refactored my code for this fix and the fix for #22102.

 The main changes are:

  * I created the get_data_directory() function suggested above and
 replaced instances of DataDirectory with it where possible.
  * I've changed make_path_absolute() to use the tor starting directory
 instead of the current directory to make an absolute path and moved it to
 util.c.
  * I've changed expand_filename() to return an absolute path.

 The branch is here:
 https://github.com/Jigsaw52/tor/tree/relative_paths_fixes

 This fixes #22101, #22102 and #20456.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22101#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online