[tor-bugs] #22101 [Core Tor/Tor]: Can't have relative DataDirectory with CookieAuthentication enabled

[Tor Bug Tracker & Wiki]

#22101: Can't have relative DataDirectory with CookieAuthentication enabled
--------------------------+------------------------------------
 Reporter:  pastly        |          Owner:
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 What about the third case of the options_get_datadir_fname2_suffix(),
 where we just copy the entire DataDirectory into the fname output?

 On the whole, let me suggest an alternative fix to this problem:  There
 are over 30 places in the codebase where we refer to
 options->DataDirectory in one way or another. What if they were all
 replaced with a function like `get_data_directory()`, and
 options->DataDirectory were only used inside functions that cared what the
 user actually typed?  That one function could be the place that makes
 DataDirectory an absolute path.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22101#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online