[tor-bugs] #22103 [Core Tor/Tor]: confparse.c checks pointer instead of value (!ok)

[Tor Bug Tracker & Wiki]

#22103: confparse.c checks pointer instead of value (!ok)
--------------------------+------------------------------------
 Reporter:  nullius       |          Owner:  catalyst
     Type:  defect        |         Status:  closed
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:  fixed
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Good find; merging!

 We do this kind of variable reuse all over the unit tests now, I fear --
 we should try to fix this pattern whenever we run into it, though, because
 it is indeed error-prone.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22103#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online