[tor-bugs] #19607 [Metrics/metrics-lib]: avoid repeated keyword strings

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed May 3 08:56:40 UTC 2017


#19607: avoid repeated keyword strings
---------------------------------+-----------------------------------
 Reporter:  iwakeh               |          Owner:  karsten
     Type:  enhancement          |         Status:  needs_review
 Priority:  Medium               |      Milestone:  metrics-lib 2.0.0
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+-----------------------------------
Changes (by karsten):

 * status:  new => needs_review


Comment:

 There, I started replacing keywords in server descriptors in
 [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/log/?h=task-19607 my task-19607 branch].  But I had trouble with
 enums and decided to switch over to constants.  If you know how to use
 enums here without bloating the code, please go for it!  As soon as we
 have a solution we like, I'm happy to do the remaining replacements.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19607#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list