[tor-bugs] #22103 [Core Tor/Tor]: confparse.c checks pointer instead of value (!ok)

[Tor Bug Tracker & Wiki]

#22103: confparse.c checks pointer instead of value (!ok)
--------------------------+------------------------------------
 Reporter:  nullius       |          Owner:  catalyst
     Type:  defect        |         Status:  accepted
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by catalyst):

 * status:  assigned => accepted


Comment:

 I am almost certain this is not a bug for reasons dgoulet and I discussed
 in IRC.  With this config line
 {{{
 HeartbeatPeriod 21 snarks
 }}}
 I get
 {{{
 May 01 13:45:21.694 [notice] Tor 0.3.0.5-rc (git-5eb2786600014d02) running
 on Darwin with Libevent 2.0.22-stable, OpenSSL 1.0.2k and Zlib 1.2.5.
 }}}
 {{{
 May 01 13:45:44.865 [warn] Unknown unit 'snarks'.
 May 01 13:45:44.865 [warn] Failed to parse/validate config: Interval
 'HeartbeatPeriod 21 snarks' is malformed or out of bounds.
 }}}
 Deleting the offending 4 lines of code makes more sense so it won't be
 doing useless checks that "look wrong", so I'll do that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22103#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online