[tor-bugs] #21771 [Core Tor/Tor]: Cannot change bridge (with Tor 0.3.0.4-rc)

[Tor Bug Tracker & Wiki]

#21771: Cannot change bridge (with Tor 0.3.0.4-rc)
---------------------------------+------------------------------------
 Reporter:  torvlnt33r           |          Owner:  asn
     Type:  defect               |         Status:  needs_review
 Priority:  Very High            |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor         |        Version:  Tor: 0.3.0.4-rc
 Severity:  Normal               |     Resolution:
 Keywords:  bridge 030-backport  |  Actual Points:
Parent ID:                       |         Points:  1
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------------
Changes (by asn):

 * status:  assigned => needs_review


Comment:

 Replying to [comment:7 asn]:
 > With Nick we discussed that the right fix is probably to implement the
 original intention of the code snippet here:
 > {{{
 > get_max_sample_size(guard_selection_t *gs,
 >                     int n_guards)
 > {
 > ...
 >   /* With bridges, max_sample is "all of them" */
 >   if (using_bridges)
 >     return n_guards;
 > }}}
 >
 > and actually make the max_sample size be "all of them" in the bridge
 case instead of just being the number of bridges in torrc.
 >
 > Possible implementations:
 >
 > a) The obvious (but slightly dirty) way of doing this would be to change
 `return n_guards` above to `return INT_MAX`. I verified that this would
 fix the bug of this ticket.
 >

 Please check my branch `bug21771` for a fix using logic (a) above.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21771#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online