[tor-bugs] #21810 [Core Tor/Tor]: Port rebind should not be performed after soft accounting limit reached

[Tor Bug Tracker & Wiki]

#21810: Port rebind should not be performed after soft accounting limit reached
----------------------------+----------------------------------------------
     Reporter:  teor        |      Owner:
         Type:  defect      |     Status:  new
     Priority:  Medium      |  Milestone:  Tor: 0.3.0.x-final
    Component:  Core        |    Version:  Tor: 0.2.9.10
  Tor/Tor                   |
     Severity:  Normal      |   Keywords:  regression?, easy, 029-backport?
Actual Points:              |  Parent ID:
       Points:  0.5         |   Reviewer:
      Sponsor:              |
----------------------------+----------------------------------------------
 A relay operator reports:
 * their relay had accounting set
 * it reached the soft limit and marked all connections for close
 * when the period ended, it estimated that it would be active for the
 entire period
 * then it attempted to rebind to ports, even though it had never closed
 the listeners

 This appears to be a simple state management issue:
 https://lists.torproject.org/pipermail/tor-relays/2017-March/012151.html

 I don't think the issue is restricted to OpenBSD.

 I don't know if it's a regression, and I don't know if it should be fixed
 in 0.3.0. Given how annoying and confusing it is, we should probably
 backport it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21810>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online