[tor-bugs] #21745 [Applications/Tor Browser]: Catch-all circuits are not working properly in ESR 52 based Tor Browser

[Tor Bug Tracker & Wiki]

#21745: Catch-all circuits are not working properly in ESR 52 based Tor Browser
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton, tbb-7.0-must,         |  Actual Points:
  ff52-esr, TorBrowserTeam201703R                |
Parent ID:  #21201                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * status:  needs_revision => needs_review
 * keywords:  tbb-torbutton, tbb-7.0-must, ff52-esr, TorBrowserTeam201703 =>
     tbb-torbutton, tbb-7.0-must, ff52-esr, TorBrowserTeam201703R


Comment:

 Replying to [comment:6 gk]:
 > Replying to [comment:5 arthuredelstein]:
 > > Here's a patch for review:
 > > https://github.com/arthuredelstein/torbutton/commit/21745+1
 >
 > That breaks the circuit display for me. After applying the patch on top
 of the other ones in `21201+3` no circuits are shown in the display
 anymore.

 Phooey. Thanks for catching this mistake. Here's a new version that
 doesn't break the circuit display.
 https://github.com/arthuredelstein/torbutton/commit/21745+2

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21745#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online