[tor-bugs] #21789 [Core Tor/Tor]: Use cached address values more often

[Tor Bug Tracker & Wiki]

#21789: Use cached address values more often
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:
         Type:  enhancement   |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.1.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:  3             |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 arma said in #20423:

 Once we get this one in, we might in 0.3.0 consider changing many more of
 these calls to cache_only=1. In fact, if we leave
 check_descriptor_ipaddress_changed() calling resolve_my_address() once a
 minute, maybe we're all set and the whole of
 router_pick_published_address() can just look at the cached values? I
 didn't want to make an invasive change like that in 0.2.9 though, since
 there are probably edge cases we care about, e.g. where
 getinfo_helper_misc() calls router_pick_published_address() and we're not
 a relay so we've never called resolve_my_address() before that very
 moment.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21789>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online