[tor-bugs] #21723 [Applications/Tor Browser]: Fix inconsistent generation of MOZ_MACBUNDLE_ID

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Mar 15 00:11:13 UTC 2017


#21723: Fix inconsistent generation of MOZ_MACBUNDLE_ID
--------------------------------------+------------------------------
 Reporter:  teor                      |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201703R     |  Actual Points:
Parent ID:  #17670                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------

Comment (by teor):

 Replying to [comment:5 gk]:
 > In the commit message you write "This results in an OSX bundle ID of
 org.torproject.torbrowser." but we adapt the descriptors for Linux and
 Windows as well. I am fine doing that if it fixes a more generic issue
 (does it?) but then we should amend the commit message.

 The build change `--with-distribution-id=org.torproject` changes the
 distribution ID on all platforms. I'm not sure how the distribution ID is
 used on Linux or Windows, but we should be consistent.

 The configure change is to MOZ_MACBUNDLE_ID, I assume it is only used on
 macOS.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21723#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list