[tor-bugs] #21724 [Applications/Tor Browser]: Distinguish between Tor Browser and Firefox when macOS opens documents

[Tor Bug Tracker & Wiki]

#21724: Distinguish between Tor Browser and Firefox when macOS opens documents
--------------------------------------+------------------------------
 Reporter:  teor                      |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201703R     |  Actual Points:
Parent ID:  #17670                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------

Comment (by teor):

 Replying to [comment:3 mcs]:
 > While I do not object to this change, we should test and see if this
 change is needed. I have the impression (but no hard data) that the
 creator code is not used by OSX and that only the bundle ID is important.

 Apple has deprecated the creator code, but still uses it in their
 implementation for backwards-compatibility reasons.

 They are not mentioned at all in:
 https://developer.apple.com/library/content/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html

 But here's how I can reproduce the Tor Browser / Firefox confusion on
 macOS 10.12.3:
 1. Install Firefox and Tor Browser
 2. `touch empty.html`
 3. In Finder, Get Info on empty.html
 4. Set "Open With" to Tor Browser
 5. Make sure both Firefox and Tor Browser are not running
 6. Open empty.html with the Finder
 (Either Firefox or Tor Browser will open depending on their order in the
 LaunchServices database, which depends on installation and maybe previous
 view/open order, and then if Tor Browser opens, Tor Launcher fails to
 handle the open request, so the default browser will open instead, see
 #20105)
 7. Make sure Firefox is running and Tor Browser is not running
 8. Open empty.html with the Finder
 (Firefox opens, even though we said to Open in Tor Browser)
 9. Make sure Tor Browser is running and Firefox is not running
 10. Open empty.html with the Finder
 (Tor Browser opens)
 11. Make sure Tor Browser and Firefox are both running
 12. Open empty.html with the Finder
 (Either Firefox or Tor Browser will open depending on their order in the
 LaunchServices database, which depends on installation and maybe previous
 view/open/launch order)

 What I expect to happen is that Tor Browser opens every time, and Firefox
 or the default browser do not open.

 > And I do not think Apple maintains a registry any more.

 Yes, this is true. But we should try not to conflict with Mozilla's
 potential future uses, if any.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21724#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online