[tor-bugs] #21309 [Applications/Tor Browser]: Fix Omnibox for TBB/52ESR

[Tor Bug Tracker & Wiki]

#21309: Fix Omnibox for TBB/52ESR
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  ff52-esr, tbb-7.0-must,              |  Actual Points:
  TorBrowserTeam201703R                          |
Parent ID:  #20680                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:18 mcs]:
 > Replying to [comment:12 arthuredelstein]:
 > > For some reason removing all but the default entry doesn't work, even
 for US English. nsSearchService.js is pretty convoluted so I'm not sure
 why. My current approach is to change all locales we deploy to include the
 same search engine list, and then rely on our #18915 patches for tor-
 browser-bundle.git to copy these search engines and the list to each
 locale xpi. It's awkward, but it seems like it should work. Unfortunately
 I'm having trouble getting tor-browser-bundle.git to build right now, so I
 haven't fully tested this. But here is the patch in any case:
 > >
 > > https://github.com/arthuredelstein/tor-browser/commit/21309+1
 >
 > This patch looks okay, except should the URLs in ddg-onion.xml be https
 instead of http?

 Good point. I changed that.

 > Regarding the changes needed for packaging (builders/tor-browser-
 bundle.git), Kathy and I wonder if it will work to simply remove
 `browser/chrome/$LOCALE/locale/browser/searchplugins` from each of the
 language packs. But we have not tried it.

 I tried this and couldn't get it to work. It seems Firefox doesn't fall
 back to the default plugins list as I would have expected. But I could be
 missing something. In any case I added the patch to my 20680 branch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21309#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online