[tor-bugs] #21693 [Core Tor/Tor]: prop224 HS descriptors do wasteful double-base64 encoding

[Tor Bug Tracker & Wiki]

#21693: prop224 HS descriptors do wasteful double-base64 encoding
----------------------------+------------------------------------
 Reporter:  asn             |          Owner:
     Type:  task            |         Status:  new
 Priority:  Medium          |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  tor-hs prop224  |  Actual Points:
Parent ID:  #21334          |         Points:  4
 Reviewer:                  |        Sponsor:  SponsorR-can
----------------------------+------------------------------------

Comment (by asn):

 Replying to [comment:1 teor]:
 > I'm not sure I understand the issue here: what stops you replacing
 `base64(encrypt(inner_layer))` with `encrypt(inner_layer)`?
 > Is there some requirement that it be plain-text?

 Hmm, I think it's because we use the routerparse API (`tokenize_string()`
 etc.)  to parse each layer, and the routerparse API mainly works on NUL-
 terminated strings.

 Maybe we could play with the `start` and `end` arguments of
 `tokenize_string()` to tell it where it should stop parsing due to binary
 data. In that case, I think we would need some sort of separator between
 the ASCII part of the descriptor layer and the binary part of the
 descriptor layer.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21693#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online