[tor-bugs] #21621 [Core Tor/Tor]: Intro points can get stuck in CIRCUIT_PURPOSE_S_ESTABLISH_INTRO

[Tor Bug Tracker & Wiki]

#21621: Intro points can get stuck in CIRCUIT_PURPOSE_S_ESTABLISH_INTRO
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  teor
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.7.2-alpha
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs        |  Actual Points:
Parent ID:  #21446        |         Points:  1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by asn):

 Hey hey, good catch and I agree this is something to be fixed.

 Some review points:

 - How come we ended up with 5 minutes as the timeout? The math in
 comment:5 do not seem to indicate 5 minutes anywhere? Shouldn't it be 240
 seconds? Also not sure what the 13.5 minutes value is.

   FWIW, personally I feel like 5 minutes is a reasonable/conservative
 timeout value for what we are aiming here.

 - I think it would be better if the new logic added in
 `remove_invalid_intro_points()` was actually a function of its own. This
 way we don't polute the host function this much, and we can also reuse
 that function (with mods) for prop224.

 - Maybe rename `MAX_INTRO_TIMEOUT` to
 `MAX_INTRO_NOT_ESTABLISHED_CIRC_TIMEOUT` or something a bit more
 meaningful?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21621#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online