[tor-bugs] #21654 [Core Tor/Tor]: Don't use fgets() when we might get EAGAIN

[Tor Bug Tracker & Wiki]

#21654: Don't use fgets() when we might get EAGAIN
--------------------------+----------------------------------
 Reporter:  nickm         |          Owner:  ahf
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------
Changes (by ahf):

 * status:  needs_revision => needs_review


Comment:

 I've updated https://gitlab.com/ahf/tor/commits/bugs/21654 to add an
 additional patch that refactors out our usage of `FILE*` in the Unix paths
 in the utility functions around `process_handle_t`.

 I've also opened #21678 which is a refactoring patch which is related to
 this issue, but I do not have access to a Windows machine to test it on
 currently.

 This additional patch passes `make check` on OS X, Linux (glibc), OpenBSD,
 FreeBSD, and HardenedBSD.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21654#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online