[tor-bugs] #21654 [Core Tor/Tor]: Don't use fgets() when we might get EAGAIN

[Tor Bug Tracker & Wiki]

#21654: Don't use fgets() when we might get EAGAIN
--------------------------+----------------------------------
 Reporter:  nickm         |          Owner:  ahf
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------
Changes (by ahf):

 * status:  assigned => needs_review


Comment:

 I've made a patch on branch 'bugs/21654' in my Gitlab Tor repository:

 https://gitlab.com/ahf/tor/commits/bugs/21654

 This patch should hopefully make the race condition go away for good.

 I've tested it on Linux (glibc), FreeBSD, HardenedBSD, OS X, and OpenBSD.
 Thanks to rubiate in #tor-dev for providing me access to an OpenBSD host.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21654#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online