[tor-bugs] #15988 [Applications/Tor Browser]: Update Tor Browser design documentation for 6.5

[Tor Bug Tracker & Wiki]

#15988: Update Tor Browser design documentation for 6.5
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-spec, TorBrowserTeam201703R,     |  Actual Points:
  GeorgKoppen201703                              |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_information => needs_revision


Comment:

 Replying to [comment:56 mikeperry]:
 > Ok, I attached a second follow-on patch that updates the speculative
 connect subsection. It gives what I hope is a more clear description of
 what we do and why we do it. It is written assuming that rel=prefetch and
 rel=prerender are also properly isolated for cache and other state via the
 existing rel=preconnect patch. If the investigation in #21657 finds this
 not to be the case, then we need to either fix it, or disable prefetching
 and prerendering and update this patch to say so.
 >
 > Leaving this as needs_information until #21657 is resolved for that
 reason.

 {{{
 Explicit preconnects via the <command>rel</command> attribute are still
 performed, however.
 }}}

 This is muddying the waters because `rel="preconnect"` things are not
 performed even if they are explicit. You linked to the bug in the sentence
 before the quote which is explaining the findings. The terminal output
 indicating that there is indeed a connection is lying as those preconnect
 things are cancelled at a deeper level.

 An easy way to fix this is by picking up the distincion you made by adding
 "and prefetched" into the section caption:
 {{{
 Prefetches via the <command>rel</command> attribute are still performed,
 however.
 }}}
 This would make it clear that we are making a somewhat similar distinction
 to the spec which has resource hint links and speculative fetches
 (confusingly, though, `prefetch` and `prerender` are mentioned as example
 of the former as well (section 2) but looking at the spec further down it
 seems to talk only about speculative fetches in relation to them).

 Marking this second fixup as `needs_revision`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15988#comment:57>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online