[tor-bugs] #6355 [Metrics/Atlas]: Distinguish between running relays and non-running relays which last had the Running flag

[Tor Bug Tracker & Wiki]

#6355: Distinguish between running relays and non-running relays which last had
the Running flag
---------------------------+------------------------------
 Reporter:  karsten        |          Owner:  phw
     Type:  enhancement    |         Status:  needs_review
 Priority:  High           |      Milestone:
Component:  Metrics/Atlas  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------------

Comment (by cypherpunks):

 Replying to [comment:20 RaBe]:
 > Okay, so here's a new patch, that adds an "offline" label, greys out the
 flags, and uses "was" instead of "is" for each tooltip (which works on
 most of the texts - I didn't want us to have to maintain an extra text
 version for every tooltip).
 On hover the line under the nicknames runs till the offline label. The
 following patch fixes that.
 {{{
 diff --git a/templates/search/do.html b/templates/search/do.html
 index 1203947..2466c4e 100644
 --- a/templates/search/do.html
 +++ b/templates/search/do.html
 @@ -71,9 +71,7 @@
  <% _.each(relays, function(relay) { %>
              <tr class="<%= i % 2 == 0 ? 'even' : 'odd' %><%=
 (relay.get('running') === false) ? ' down' : '' %>">
                         <td>
 -            <a href="#details/<%= relay.get('fingerprint') %>">
 -            <%= _.escape(relay.get('nickname')) %>
 -            </a>
 +            <a href="#details/<%= relay.get('fingerprint') %>"><%=
 _.escape(relay.get('nickname')) %></a>
              <% if (relay.get('running') === false) { %><span class="label
 label-important">offline</span><% } %>
              </td>
                         <td><span data-filter="<%= relay.get('bandwidth')
 %>"><%= relay.get('bandwidth_hr') %></td>
 }}}
 The greyed out flags look good IMO. However, the simplistic replacement of
 'is' with 'was' leads to some weird sentences and, like you said, it only
 applies to most of the texts. This makes most sentences use the past tense
 but some use the present tense which is confusing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6355#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online