[tor-bugs] #21308 [Applications/Tor Browser]: Fix modernizr breakage for TBB/ESR52

[Tor Bug Tracker & Wiki]

#21308: Fix modernizr breakage for TBB/ESR52
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201703R,     |  Actual Points:
  tbb-7.0-must                                   |
Parent ID:  #20680                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * status:  needs_information => needs_review


Comment:

 Replying to [comment:8 gk]:
 > Replying to [ticket:21308 arthuredelstein]:
 > > Our patch for #16528 doesn't work with electrolysis enabled, so we
 need a new patch for TBB/ESR52.
 >
 > Hm. Do you happen to know why that's the case? Because what we do with
 the patch we currently have is just disabling the pref checks and relying
 solely on private browsing mode (PBM) checks. And surely, IndexedDB is
 still disabled in PBM. Thus, those checks should still work as-is.

 The old patch was causing crashes with e10s. I don't know why.

 > Second point, I assume the patch in comment:5 works as well with e10s
 disabled? Because it is still unclear right now how stable e10s will be in
 a Tor Browser ESR52. We might need to disable it or enable it later.

 In my hands it seems to be working OK with e10s enabled or disabled.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21308#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online