[tor-bugs] #21514 [Applications/Tor Browser]: Deal with W^X backport bustage in upcoming ESR release

[Tor Bug Tracker & Wiki]

#21514: Deal with W^X backport bustage in upcoming ESR release
--------------------------------------+---------------------------------
 Reporter:  gk                        |          Owner:  arthuredelstein
     Type:  task                      |         Status:  closed
 Priority:  Very High                 |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Critical                  |     Resolution:  fixed
 Keywords:  TorBrowserTeam201703R     |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+---------------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Alright, thanks for the manual testing. I decided to include the new patch
 into the upcoming stable series as

 1) we retain `W^X` JIT support that way
 2) the patch looks good to all of us
 3) the patch looks good to Jan de Mooji
 4) the patch contains in large parts code that is in mozilla-central
 5) we verified manually that it works on all three platforms
 6) we did not encounter any crashes (which would be pretty easy to trigger
 (at least I'd assume so))

 I kept the other two backported patches as well. Those three patches are
 on `tor-browser-45.8.0esr-6.5-2` now as commit
 ad729fa2597d44b1d128a66d07b89e849e44cb80,
 a86798d665931a7250d44366faaad812a36d38b2, and
 f01f8bf4c84420e8f3538a4b9a978a7a2383a8c6.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21514#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online