[tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
--------------------------+------------------------------------
 Reporter:  mcs           |          Owner:  nickm
     Type:  defect        |         Status:  reopened
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.0.3-alpha
 Severity:  Normal        |     Resolution:
 Keywords:  tbb-wants     |  Actual Points:  .2
Parent ID:                |         Points:  2
 Reviewer:  dgoulet       |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * keywords:  tbb-wants 029-backport => tbb-wants
 * version:   => Tor: 0.3.0.3-alpha
 * type:  enhancement => defect


Comment:

 This is now a defect, the original feature was released in 0.3.0.3-alpha.

 Replying to [comment:22 meejah]:
 > Testing against master (9af76a9) for existing control-port using
 software, this enhancement changes the "type" given by `getinfo
 config/names` from `LineList` to `Dependent`

 > (which is also a spelling change from last release where it's
 `Dependant`).

 That was #18146.

 > Prior to now, the only thing which had the `Virtual` +
 `Dependent`/`Dependant` things was the hidden-service stuff (and only
 because order matters, according to control-spec).
 >
 > Ideally, `SocksPort` et al. would still report their type as `LineList`.
 Also, my understanding of the use of `Virtual` + `Dependent` was for
 options whose order matters. This doesn't appear to be the case here
 (unless I'm missing something?). If these *do* need to be Virtual then
 control-spec should be updated.
 >
 > txtorcon uses `getinfo config/names` to programmatically decide which
 parsers to use for options; I don't know if other control-port software
 does as well. I could of course just special-case all these new ones
 (which is the only solution currently) but the change from `LineList` ->
 `Dependant` seems unnecessary for this feature.
 >
 > (As an aside, I would personally like to see `Virtual` + `Dependent` go
 away entirely as it's the only special-case weird order-dependent thing in
 SETCONF).

 meejah also noted on IRC that "getconf SocksPortLines" doesn't work.

 This sounds a lot like #21300.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20956#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online