[tor-bugs] #20988 [Core Tor/Tor]: Test fgets_eagain fails on FreeBSD-amd64

[Tor Bug Tracker & Wiki]

#20988: Test fgets_eagain fails on FreeBSD-amd64
------------------------------------------------+--------------------------
 Reporter:  cypherpunks                         |          Owner:
     Type:  defect                              |         Status:
                                                |  needs_review
 Priority:  Medium                              |      Milestone:  Tor:
                                                |  0.3.1.x-final
Component:  Core Tor/Tor                        |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  freebsd, tor-03-unspecified-201612  |  Actual Points:
Parent ID:                                      |         Points:
 Reviewer:                                      |        Sponsor:
------------------------------------------------+--------------------------
Changes (by ahf):

 * cc: ahf (added)
 * status:  needs_revision => needs_review


Comment:

 I've updated my branch with the following changes:

 - Fixed typos reported by OP. Thanks!
 - Added a changes file.
 - We now clear the error flag on the file handler in the case where
 `ferror(stream) && errno == EAGAIN` to prevent the situation where the
 caller receives an error return value and retries because of `errno` being
 `EAGAIN`, but continues to have the error flag set.

 I ran `make check` and tested it with "normal" browsing usage on OS X,
 HardenedBSD, and Linux.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20988#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online