[tor-bugs] #22762 [Core Tor/Tor]: Revise coding standards expectation for tests to be run before review

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Jun 29 00:12:48 UTC 2017


#22762: Revise coding standards expectation for tests to be run before review
------------------------------+------------------------------
     Reporter:  chelseakomlo  |      Owner:  chelseakomlo
         Type:  task          |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: unspecified
    Component:  Core Tor/Tor  |    Version:  Tor: unspecified
     Severity:  Normal        |   Keywords:  documentation
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:  catalyst
      Sponsor:                |
------------------------------+------------------------------
 There are several make targets with varying combinations of tests that are
 run.

 Currently, we expect contributors to run the full test suite, including
 integration tests. This is a lot to ask, especially for new contributors.

 Instead, let's require `make check`, but advise `make test-full` on
 feature changes and larger commits.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22762>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list