[tor-bugs] #22746 [Core Tor/Tor]: CID 1413651: No retval check in ed25519_donna_blind_public_key()

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jun 28 13:13:40 UTC 2017


#22746: CID 1413651:  No retval check in ed25519_donna_blind_public_key()
--------------------------+------------------------------------
 Reporter:  asn           |          Owner:
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  coverity      |  Actual Points:
Parent ID:                |         Points:  0.1
 Reviewer:                |        Sponsor:  SponsorR-can
--------------------------+------------------------------------
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 OK pushed two more commits on branch `bug22746`.
 One commits adds unittests that trigger the error paths, the other commit
 adds a changes file.

 The blinding functions will be used by prop224 client/service code which
 has not been merged yet, so the buggy code is not yet used in real life
 IIUC.

 Placing this back in `needs_review`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22746#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list