[tor-bugs] #7869 [Core Tor/Tor]: ntor-onion-key is padded with an equal sign

[Tor Bug Tracker & Wiki]

#7869: ntor-onion-key is padded with an equal sign
-----------------------------------------------+---------------------------
 Reporter:  rransom                            |          Owner:  Jigsaw52
     Type:  defect                             |         Status:
                                               |  needs_revision
 Priority:  Low                                |      Milestone:  Tor:
                                               |  0.3.2.x-final
Component:  Core Tor/Tor                       |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tor-relay, intro, review-group-18  |  Actual Points:
Parent ID:                                     |         Points:
 Reviewer:  catalyst, nickm                    |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Additionally:
  * I'm concerned about test coverage. Has anyone checked?
  * curve25519_public_to_base64 seems to have gotten a lot longer than
 before. Maybe there should be a way to pass the no-padding flag downward
 to the base64_encode function.  Or maybe
 curve25519_public_to_base64_nopad() should be a separate function?  It
 seems that nearly all callers of curve25519_public_to_base64() use the no-
 padding variant, and this patch would be much simpler without having an
 extra argument added.
  * It doesn't seem that authorities actually advertise or allow support
 for MIN_METHOD_FOR_UNPADDED_NTOR_KEY.  See MAX_SUPPORTED_CONSENSUS_METHOD
 and its users for the necessary changes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7869#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online