[tor-bugs] #22720 [Core Tor/Tor]: Don't exit(0) on error: exit(1) instead

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Jun 26 17:59:56 UTC 2017


#22720: Don't exit(0) on error: exit(1) instead
--------------------------------------------+------------------------------
 Reporter:  nickm                           |          Owner:
     Type:  defect                          |         Status:  merge_ready
 Priority:  Medium                          |      Milestone:  Tor:
                                            |  0.3.1.x-final
Component:  Core Tor/Tor                    |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  tor-relay exit error-code easy  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 I did a pass at the 17 places where we `exit(0)` and the proposed patch
 does fixes the 3 callsites that are errors.

 lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22720#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list