[tor-bugs] #22720 [Core Tor/Tor]: Don't exit(0) on error: exit(1) instead

[Tor Bug Tracker & Wiki]

#22720: Don't exit(0) on error: exit(1) instead
------------------------------+--------------------------------------------
     Reporter:  nickm         |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.1.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-relay exit error-code easy
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------------------
 per recent tor-talk thread, there are several places in our code where we
 exit(0) on an error, and we should exit(1) instead.

 When fixing this, it's a good idea to check every exit(0) to see whether
 it's an error or an expected exit condition.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22720>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online