[tor-bugs] #22717 [Core Tor/Tor]: Rename channelpadding.c's CHANNEL_IS_CLIENT to avoid confusion

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat Jun 24 01:49:40 UTC 2017


#22717: Rename channelpadding.c's CHANNEL_IS_CLIENT to avoid confusion
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.3.1.x-final
    Component:  Core     |    Version:  Tor: 0.3.1.1-alpha
  Tor/Tor                |   Keywords:  technical-debt, disaster-waiting-
     Severity:  Normal   |  to-happen, 031-deferrable
Actual Points:           |  Parent ID:
       Points:  0.1      |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 There is already a channel_is_client() function in channel.[ch], with
 different arguments and semantics.

 And while we're doing that, we should make the newly renamed
 CHANNEL_IS_CLIENT() call channel.h's channel_is_client(), because it's the
 right abstraction to use.

 We could survive releasing 0.3.1 without this fix, because it's not a bug
 (yet).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22717>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list