[tor-bugs] #22608 [Core Tor/Tor]: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Jun 21 18:00:24 UTC 2017
#22608: Refactor connection_or_set_state(OPEN) to connection_or_set_state_open()
-----------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: review-group-18 | Actual Points:
Parent ID: | Points: .2
Reviewer: | Sponsor:
-----------------------------+------------------------------------
Comment (by nickm):
Replying to [comment:4 catalyst]:
> Looks mostly good.
Thanks for the review!
> A few nits: callgraph reduction numbers don't match between commit
message and this ticket; also it fails check-spaces.
Will fix; the numbers have fluctuated between when I originally wrote the
patch and now. Right now the reduction is 58 -> 28.
> If it's a factor-of-three reduction in the largest SCC then maybe it
should get a changes file, too?
Will fix that too. Thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22608#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list