[tor-bugs] #22674 [Metrics/metrics-lib]: Consider changing instance methods to static methods

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Jun 20 19:11:40 UTC 2017


#22674: Consider changing instance methods to static methods
---------------------------------+------------------------------
 Reporter:  karsten              |          Owner:  metrics-team
     Type:  enhancement          |         Status:  new
 Priority:  Medium               |      Milestone:
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------

Comment (by karsten):

 Replying to [comment:1 iwakeh]:
 > I think the entire structure needs some improvement.

 Agreed.

 > This small change is useful to mark methods that don't rely on instance
 variables/methods as 'static'.
 > Anyway, `parseDescriptors` used to be static before and that was just
 changed (I missed the reason).

 Ah, heh, mainly because I thought it was an oversight that it was static
 before.  Happy to reconsider (without the time constraint of
 wanting/needing to put out two releases within 10 days)!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22674#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list