[tor-bugs] #22660 [Core Tor/Tor]: Guard against stack smashing attacks in tor

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Jun 20 13:45:16 UTC 2017


#22660: Guard against stack smashing attacks in tor
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hardening, security              |  Actual Points:
  029-backport 030-backport 031-backport         |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted
 * keywords:  tor-hardening, security => tor-hardening, security
     029-backport 030-backport 031-backport


Comment:

 We already have -fstack-protector-all, but I guess it doesn't include
 this?

 Also, we should never be installed SUID, yeah?

 That said, this is indeed a pretty trivial change; see my branch
 `harden_22660_029`, for 0.3.2 and possible backport as far as 0.2.9

 When I try to build with this, I get many `/usr/bin/ld: warning: -z
 noexecheap ignored.` warnings.  I don't know if that's something I should
 be concerned about.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22660#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list