[tor-bugs] #22514 [Metrics/metrics-lib]: Replace DescriptorReader's setMaxDescriptorFilesInQueue() with setMaxMemory()

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Jun 19 13:48:55 UTC 2017


#22514: Replace DescriptorReader's setMaxDescriptorFilesInQueue() with
setMaxMemory()
---------------------------------+-----------------------------------
 Reporter:  karsten              |          Owner:  metrics-team
     Type:  enhancement          |         Status:  needs_review
 Priority:  Medium               |      Milestone:  metrics-lib 1.9.0
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+-----------------------------------

Comment (by iwakeh):

 I'd prefer the 'descriptor count' solution.  Specifying bytes is in a way
 giving the illusion one could fine tune the jvm heap here, it hints a
 closeness to jvm details we don't have and want.
 So, the abstract choice of descriptor count and using a Java collection is
 best in my view.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22514#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list