[tor-bugs] #22514 [Metrics/metrics-lib]: Replace DescriptorReader's setMaxDescriptorFilesInQueue() with setMaxMemory()

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Jun 19 13:26:41 UTC 2017


#22514: Replace DescriptorReader's setMaxDescriptorFilesInQueue() with
setMaxMemory()
---------------------------------+-----------------------------------
 Reporter:  karsten              |          Owner:  metrics-team
     Type:  enhancement          |         Status:  needs_review
 Priority:  Medium               |      Milestone:  metrics-lib 1.9.0
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+-----------------------------------

Comment (by iwakeh):

 I really want direct unit tests for the new functionality of
 `BlockingIteratorImpl`.

 There are some (older) `System.err.printf` statements that should be
 turned into log statements.

 With this change `BlockingIteratorImpl` is not generic anymore as it now
 is tightly coupled with Descriptor and DescriptorFile.  So, it seems
 better to either make it a BlockingDescriptorIterator or derive
 BlockingDescriptorIterator from the generic old implementation (if
 possible) or find another way of keeping it decoupled from
 Descriptor/Desc.File.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22514#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list