[tor-bugs] #22644 [Core Tor/Tor]: Assert crash with HSPOST and POSTDESCRIPTOR control port commands

[Tor Bug Tracker & Wiki]

#22644: Assert crash with HSPOST and POSTDESCRIPTOR control port commands
------------------------------+-----------------
     Reporter:  donncha       |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+-----------------
 The HSPOST and POSTDESCRIPTOR control port command accept multi-line data.
 Both of these commands crash when they receive an empty command body.

 A trivial test case is as follows:
 {{{
 AUTHENTICATE
 +HSPOST
 .
 }}}

 Stacktraces:
 {{{
 Jun 18 19:27:41.000 [err] tor_assertion_failed_(): Bug:
 ../src/or/control.c:3098: handle_control_postdescriptor: Assertion cp
 failed; aborting. (on Tor 0.2.8.9 )
 Jun 18 19:27:41.000 [err] Bug: Assertion cp failed in
 handle_control_postdescriptor at ../src/or/control.c:3098. Stack trace:
 (on Tor 0.2.8.9 )
 Jun 18 19:27:41.000 [err] Bug:     tor(log_backtrace+0x42)
 [0x564171496242] (on Tor 0.2.8.9 )
 Jun 18 19:27:41.000 [err] Bug:     tor(tor_assertion_failed_+0x94)
 [0x5641714a44f4] (on Tor 0.2.8.9 )
 Jun 18 19:27:41.000 [err] Bug:
 tor(connection_control_process_inbuf+0x279a) [0x5641714602da] (on Tor
 0.2.8.9 )
 Jun 18 19:27:41.000 [err] Bug:     tor(+0xe81c5) [0x56417144a1c5] (on Tor
 0.2.8.9 )
 Jun 18 19:27:41.000 [err] Bug:     tor(+0x410f1) [0x5641713a30f1] (on Tor
 0.2.8.9 )
 Jun 18 19:27:41.000 [err] Bug:     /usr/lib/x86_64-linux-
 gnu/libevent-2.0.so.5(event_base_loop+0x6a0) [0x7fe33b428420] (on Tor
 0.2.8.9 )
 Jun 18 19:27:41.000 [err] Bug:     tor(do_main_loop+0x21d)
 [0x5641713a40bd] (on Tor 0.2.8.9 )
 Jun 18 19:27:41.000 [err] Bug:     tor(tor_main+0x1b95) [0x5641713a7675]
 (on Tor 0.2.8.9 )
 Jun 18 19:27:41.000 [err] Bug:     tor(main+0x19) [0x56417139fdc9] (on Tor
 0.2.8.9 )
 Jun 18 19:27:41.000 [err] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xf1) [0x7fe33a5643f1] (on Tor 0.2.8.9 )
 Jun 18 19:27:41.000 [err] Bug:     tor(+0x3de1b) [0x56417139fe1b] (on Tor
 0.2.8.9 )
 [1]    14542 abort      tor -f torrc.local
 }}}

 {{{
 Jun 18 19:35:43.000 [err] tor_assertion_failed_(): Bug:
 ../src/common/util.c:316: tor_strndup_: Assertion n < SIZE_T_CEILING
 failed; aborting. (on Tor 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug: Assertion n < SIZE_T_CEILING failed in
 tor_strndup_ at ../src/common/util.c:316. Stack trace: (on Tor 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug:     tor(log_backtrace+0x42)
 [0x564aa98a8242] (on Tor 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug:     tor(tor_assertion_failed_+0x94)
 [0x564aa98b64f4] (on Tor 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug:     tor(tor_strndup_+0x91) [0x564aa98b6e01]
 (on Tor 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug:     tor(+0x3bef8) [0x564aa97afef8] (on Tor
 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug:
 tor(connection_control_process_inbuf+0x1e1f) [0x564aa987195f] (on Tor
 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug:     tor(+0xe81c5) [0x564aa985c1c5] (on Tor
 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug:     tor(+0x410f1) [0x564aa97b50f1] (on Tor
 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug:     /usr/lib/x86_64-linux-
 gnu/libevent-2.0.so.5(event_base_loop+0x6a0) [0x7f1ea6c60420] (on Tor
 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug:     tor(do_main_loop+0x21d)
 [0x564aa97b60bd] (on Tor 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug:     tor(tor_main+0x1b95) [0x564aa97b9675]
 (on Tor 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug:     tor(main+0x19) [0x564aa97b1dc9] (on Tor
 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xf1) [0x7f1ea5d9c3f1] (on Tor 0.2.8.9 )
 Jun 18 19:35:43.000 [err] Bug:     tor(+0x3de1b) [0x564aa97b1e1b] (on Tor
 0.2.8.9 )
 [1]    15378 abort      tor -f torrc.local
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22644>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online