[tor-bugs] #22512 [Metrics/metrics-lib]: Add enums for keywords used in exit lists, Torperf measurement results, bridge pool assignments, and soon sanitized web logs

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jun 14 11:28:33 UTC 2017


#22512: Add enums for keywords used in exit lists, Torperf measurement results,
bridge pool assignments, and soon sanitized web logs
---------------------------------+------------------------------
 Reporter:  karsten              |          Owner:  metrics-team
     Type:  enhancement          |         Status:  new
 Priority:  Medium               |      Milestone:
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------

Comment (by iwakeh):

 Right, all descriptor parsing should make use of the `Key` keywords.

 Some things to consider:
 There is no inheritance between enums.  So, the ease of use in all
 descriptor parsing code would be lost with different Key-enums.  When
 using only the general `Enum<T>` the `.keyword` and other features of
 `Key` are lost.
 This yields toward the "adding more Key enums approach" instead of
 separate Enums.

 There are no naming conventions yet (only implicitly).  The possible
 naming problems suppose certain rules which were not introduced directly.
 A working set of naming convention rules could be started with the aim of
 only using one `Key` enum.  If there are similar `Key` names as in the
 example above using 'source' a prefix could be added.  It should be ok to
 not have a strict translation rule from the actual keyword to the enum
 name; only keep it heuristically close.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22512#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list