[tor-bugs] #22141 [Metrics/metrics-lib]: Deprecate `DescriptorFile` and add relevant information to `Descriptor`
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Jun 14 09:57:29 UTC 2017
#22141: Deprecate `DescriptorFile` and add relevant information to `Descriptor`
---------------------------------+-----------------------------------
Reporter: karsten | Owner: karsten
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: metrics-lib 1.9.0
Component: Metrics/metrics-lib | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------------+-----------------------------------
Comment (by karsten):
`DescriptorIndexCollector` indeed does not parse any descriptors, and
neither did `DescriptorCollectorImpl`. But I didn't refer to
`DescriptorParseException` here. We wouldn't be able to include other
exceptions than `DescriptorParseException`, like `IOException`, in an
output by `DescriptorIndexCollector`, because there's no output. And that
was the plan for `DescriptorReader`, where we were planning to include
IOException in a returned `InvalidDescriptor`. (The code may make this
more obvious.)
I also now understand your "ParseExceptionsLog" idea better. Basically,
we would create a new structure for logging that is less dependent on
classes and more related to operation. Not opposed to that idea. I could
imagine that we'd want to look more at the other log statements and see
what other channels would be useful. How about we leave that for after
2.0.0 is released?
Can you look at the branch? I think it makes sense to look now. Thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22141#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list