[tor-bugs] #22208 [Metrics/metrics-lib]: Provide lines containing extra, unrecognized arguments

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Jun 12 09:01:19 UTC 2017


#22208: Provide lines containing extra, unrecognized arguments
---------------------------------+-----------------------------------
 Reporter:  karsten              |          Owner:  metrics-team
     Type:  enhancement          |         Status:  new
 Priority:  Medium               |      Milestone:  metrics-lib 2.0.0
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+-----------------------------------
Changes (by karsten):

 * milestone:  metrics-lib 1.9.0 => metrics-lib 2.0.0


Comment:

 I thought more about possible use cases and came up with the following
 two:

  1. When we sanitize bridge descriptors we want to know whether we did not
 fully recognize a descriptor.  We need to look at the unrecognized parts
 manually before deciding whether they can go in or not.  And in this case
 it doesn't matter whether we didn't recognize a whole line or just a line
 part.

  2. When we extend the descriptor format, either by writing a tor patch or
 by rewriting descriptors like for the directory-request Laplace noise
 simulation, we may want to parse descriptor parts that metrics-lib cannot
 yet recognize.  And in such a case it also doesn't matter whether metrics-
 lib didn't recognize the whole line or just a line part.

 I think it's easiest to simply add lines containing extra, unrecognized
 arguments to `Descriptor#getUnrecognizedLines()`, together with
 unrecognized lines.  That also keeps the interface small, as opposed to
 adding yet another method for partially unrecognized lines.  Oh, and
 dropping extra arguments on the floor also doesn't seem very useful.

 This means that we'll need to change the semantics of
 `Descriptor#getUnrecognizedLines()`, and we can only do that in 2.0.0.
 Moving to that milestone.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22208#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list