[tor-bugs] #22565 [Core Tor/Tor]: Refactor tor's signal handler to avoid undefined behaviour

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Jun 11 06:35:42 UTC 2017


#22565: Refactor tor's signal handler to avoid undefined behaviour
-------------------------------------------+-------------------------------
 Reporter:  teor                           |          Owner:
     Type:  defect                         |         Status:  new
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  unspecified
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  memory-safety, technical-debt  |  Actual Points:
Parent ID:                                 |         Points:  2
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------

Comment (by teor):

 We should declare these flags as `volatile sig_atomic_t`, set/increment
 them in the signal handler, and clear them in the main loop.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22565#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list