[tor-bugs] #22554 [Applications/Tor Browser]: Remove Battery API related bit in Torbutton

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jun 9 19:42:36 UTC 2017


#22554: Remove Battery API related bit in Torbutton
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton,                       |  Actual Points:
  TorBrowserTeam201706R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:5 mcs]:
 > Replying to [comment:4 gk]:
 > > Yes. I added that to our "catch-all"-ticket we currently have for
 clean-up (#19256).
 >
 > But shouldn't the code be fixed rather than removed? E.g.,
 `torbutton_update_thirdparty_prefs()` will never be called, but it seems
 like we want that functionality. But you or Arthur would know better than
 me.

 Good point. I think we should fix that, although the default we ship
 works. I opened #22560 for that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22554#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list