[tor-bugs] #21932 [Metrics/metrics-lib]: Stop relying on the platform's default charset

[Tor Bug Tracker & Wiki]

#21932: Stop relying on the platform's default charset
---------------------------------+-----------------------------------
 Reporter:  karsten              |          Owner:  metrics-team
     Type:  defect               |         Status:  needs_review
 Priority:  Medium               |      Milestone:  metrics-lib 1.8.0
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+-----------------------------------

Comment (by iwakeh):

 Replying to [comment:13 karsten]:
 > I just pushed one more commit to that branch to fix a bug.


 Good, that you found that!  Should there be a test added for this in
 particular?

 All looks fine, passes tests and checks.  I added a simple test class
 directly for DescriptorImpl [https://gitweb.torproject.org/user/iwakeh
 /metrics-
 lib.git/commit/?h=task-21932-3&id=991dc7bddfe6a6e692a3c580fe318ed01c23844d
 here].

 Some questions (partially not related to current changes):
 1. Rename `getScanner` into `newScanner`, because a new Scanner is created
 with every call and this is not a 'getter'?
 1. `ExitList.EOL = "\n" = DescriptorImpl.NL` why not use one for all
 delimiters in `newScanner` calls? Shouldn't `NL` be defined in
 `Descriptor` and be used everywhere, i.e., deprecate `ExitList.EOL` and
 replace with release 2.0.0?
 1. Make NL the delimiter default that is already set for the Scanner
 returned by `newScanner`?
 1. The Scanner usage in TorperfResult is essentially getLine() in the two
 places.  Do Torperf descriptors contain "\r"?
 1. DescriptorImpl.setDigestXXX allow empty or null argument.  Should there
 be a check?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21932#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online