[tor-bugs] #22460 [Core Tor/Tor]: Link handshake trouble: certificates and keys can get out of sync

[Tor Bug Tracker & Wiki]

#22460: Link handshake trouble: certificates and keys can get out of sync
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tor-relay certs handshake ed25519    |  Actual Points:  1
  needs-analysis 030-backport 029-backport       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  merge_ready => needs_review


Comment:

 Squashed the second one as bug22460_case2_029_01_squashed .  Merged it to
 0.2.9, and merged it forward with conflicts (please review
 d1c1dc229e189c).

 Merged the first to 0.3.0 and forward.  Had to add
 91f49bc0f0759d0e0a794fbfe8cce5a9bb07e607 for the tests to pass again,
 because the assert_nonfatal() I had added was triggered by some of the
 code that tested the pre-ed case.

 Going to put in needs_review till somebody's looked at the mentioned
 commits, and had a chance to test it a lot more.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22460#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online