[tor-bugs] #22460 [Core Tor/Tor]: Link handshake trouble: certificates and keys can get out of sync

[Tor Bug Tracker & Wiki]

#22460: Link handshake trouble: certificates and keys can get out of sync
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tor-relay certs handshake ed25519    |  Actual Points:  1
  needs-analysis 030-backport 029-backport       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 The `make test-network` is failing. It appears that some node aren't able
 to start due to this abort:

 {{{
 Tor 0.2.9.10-dev (git-ee0bd9760ba51f2e) died: Caught signal 11
 /home/dgoulet/Documents/git/tor/src/or/tor(+0x147869)[0x561a20e9a869]
 /lib/x86_64-linux-
 gnu/libcrypto.so.1.0.0(i2c_ASN1_INTEGER+0xf)[0x7f5f72640c6f]
 /lib/x86_64-linux-
 gnu/libcrypto.so.1.0.0(i2c_ASN1_INTEGER+0xf)[0x7f5f72640c6f]
 /lib/x86_64-linux-
 gnu/libcrypto.so.1.0.0(asn1_ex_i2c+0x154)[0x7f5f7264bad4]
 /lib/x86_64-linux-gnu/libcrypto.so.1.0.0(+0x13ebca)[0x7f5f7264bbca]
 /lib/x86_64-linux-
 gnu/libcrypto.so.1.0.0(ASN1_item_ex_i2d+0x1d6)[0x7f5f7264bea6]
 /lib/x86_64-linux-gnu/libcrypto.so.1.0.0(+0x13f3ae)[0x7f5f7264c3ae]
 /lib/x86_64-linux-
 gnu/libcrypto.so.1.0.0(ASN1_item_ex_i2d+0x3ab)[0x7f5f7264c07b]
 /lib/x86_64-linux-gnu/libcrypto.so.1.0.0(+0x13f2d8)[0x7f5f7264c2d8]
 /lib/x86_64-linux-
 gnu/libcrypto.so.1.0.0(ASN1_item_ex_i2d+0x3ab)[0x7f5f7264c07b]
 /lib/x86_64-linux-gnu/libcrypto.so.1.0.0(+0x13f1df)[0x7f5f7264c1df]
 /home/dgoulet/Documents/git/tor/src/or/tor(+0x170046)[0x561a20ec3046]
 /home/dgoulet/Documents/git/tor/src/or/tor(connection_or_compute_authenticate_cell_body+0x349)[0x561a20e581b9]
 /home/dgoulet/Documents/git/tor/src/or/tor(+0xbb340)[0x561a20e0e340]
 /home/dgoulet/Documents/git/tor/src/or/tor(channel_tls_handle_var_cell+0x623)[0x561a20e11013]
 /home/dgoulet/Documents/git/tor/src/or/tor(+0x100ba3)[0x561a20e53ba3]
 /home/dgoulet/Documents/git/tor/src/or/tor(+0xf802e)[0x561a20e4b02e]
 /home/dgoulet/Documents/git/tor/src/or/tor(+0x4253e)[0x561a20d9553e]
 /usr/lib/x86_64-linux-
 gnu/libevent-2.0.so.5(event_base_loop+0x6a0)[0x7f5f72bc7420]
 /home/dgoulet/Documents/git/tor/src/or/tor(do_main_loop+0x22d)[0x561a20d965ad]
 /home/dgoulet/Documents/git/tor/src/or/tor(tor_main+0x1c25)[0x561a20d99e55]
 /home/dgoulet/Documents/git/tor/src/or/tor(main+0x19)[0x561a20d92049]
 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1)[0x7f5f71afd3f1]
 /home/dgoulet/Documents/git/tor/src/or/tor(_start+0x2a)[0x561a20d9209a]
 }}}

 And also sometimes:

 {{{
 Tor 0.2.9.10-dev (git-ee0bd9760ba51f2e) died: Caught signal 11
 /home/dgoulet/Documents/git/tor/src/or/tor(+0x147869)[0x559a03755869]
 /lib/x86_64-linux-
 gnu/libcrypto.so.1.0.0(ASN1_template_free+0x2a)[0x7fb67edb88ca]
 /lib/x86_64-linux-
 gnu/libcrypto.so.1.0.0(ASN1_template_free+0x2a)[0x7fb67edb88ca]
 /lib/x86_64-linux-gnu/libcrypto.so.1.0.0(+0x13e672)[0x7fb67edb8672]
 /lib/x86_64-linux-
 gnu/libcrypto.so.1.0.0(ASN1_item_free+0x15)[0x7fb67edb8885]
 /lib/x86_64-linux-gnu/libcrypto.so.1.0.0(+0x13a3cd)[0x7fb67edb43cd]
 /lib/x86_64-linux-gnu/libcrypto.so.1.0.0(+0x13e698)[0x7fb67edb8698]
 /lib/x86_64-linux-
 gnu/libcrypto.so.1.0.0(ASN1_item_free+0x15)[0x7fb67edb8885]
 /home/dgoulet/Documents/git/tor/src/or/tor(tor_x509_cert_free+0x2a)[0x559a0377f91a]
 /home/dgoulet/Documents/git/tor/src/or/tor(connection_or_compute_authenticate_cell_body+0x1a6)[0x559a03713016]
 /home/dgoulet/Documents/git/tor/src/or/tor(+0xbb340)[0x559a036c9340]
 /home/dgoulet/Documents/git/tor/src/or/tor(channel_tls_handle_var_cell+0x623)[0x559a036cc013]
 /home/dgoulet/Documents/git/tor/src/or/tor(+0x100ba3)[0x559a0370eba3]
 /home/dgoulet/Documents/git/tor/src/or/tor(+0xf802e)[0x559a0370602e]
 /home/dgoulet/Documents/git/tor/src/or/tor(+0x4253e)[0x559a0365053e]
 /usr/lib/x86_64-linux-
 gnu/libevent-2.0.so.5(event_base_loop+0x6a0)[0x7fb67f334420]
 /home/dgoulet/Documents/git/tor/src/or/tor(do_main_loop+0x22d)[0x559a036515ad]
 /home/dgoulet/Documents/git/tor/src/or/tor(tor_main+0x1c25)[0x559a03654e55]
 /home/dgoulet/Documents/git/tor/src/or/tor(main+0x19)[0x559a0364d049]
 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1)[0x7fb67e26a3f1]
 /home/dgoulet/Documents/git/tor/src/or/tor(_start+0x2a)[0x559a0364d09a]
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22460#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online