[tor-bugs] #22497 [Core Tor/Tor]: Clean-up tt_assert() usage in our tests

[Tor Bug Tracker & Wiki]

#22497: Clean-up tt_assert() usage in our tests
------------------------------+--------------------------------
     Reporter:  ahf           |      Owner:
         Type:  enhancement   |     Status:  new
     Priority:  Low           |  Milestone:  Tor: 0.3.1.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 Often when refactoring code I stumble upon places in our test code where
 we use `tt_assert()` instead of the `tt_$type_op` equivalent function to
 do the various checks. It would be nice to clean this somewhat up to get
 better test case failure messages.

 This should ideally be done using Coccinelle with semantical patches.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22497>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online